Update PLIC HAL to use new autogen interface#386
Open
ziuziakowska wants to merge 1 commit intolowRISC:mainfrom
Open
Update PLIC HAL to use new autogen interface#386ziuziakowska wants to merge 1 commit intolowRISC:mainfrom
ziuziakowska wants to merge 1 commit intolowRISC:mainfrom
Conversation
ziuziakowska
changed the title
ziuziakowska
force-pushed
the
hal-autogen-rework-plic
branch
from
836d140 to
241d6d5
Compare
ziuziakowska
changed the title
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
force-pushed
the
hal-autogen-rework-plic
branch
from
241d6d5 to
8b853fa
Compare
engdoreis
reviewed
Apr 8, 2026
| void plic_init(plic_t plic); | ||
|
|
||
| uint8_t plic_interrupt_priority_read(plic_t plic, uint32_t intr); | ||
| void plic_interrupt_priority_write(plic_t plic, uint32_t intrs, uint8_t prio); |
Collaborator
There was a problem hiding this comment.
These functions with intrs needs documentation, It took me time to understand that intrs is a bit mask that can contain many interrupts.
|
|
||
| plic_interrupt_priority_set(plic, 4, 2); | ||
| if ((plic_interrupt_priority_get(plic, 4) & PLIC_PRIO_MASK) != 2) { | ||
| plic_interrupt_priority_write(plic, 4, 2); |
Collaborator
There was a problem hiding this comment.
What is intr 4? Can it be added to the enum?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #299.